[CMake] Always disable string processing import #64187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
compnerd
approved these changes
Mar 7, 2023
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Aug 7, 2025
Since swiftlang#64187 we are not importing automatically StringProcessing when building the stdlib -- this is especially important for StdlibUnittest, since it needs to run on older OSes. Addresses rdar://157622116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that a configuration that has
SWIFT_ENABLE_EXPERIMENTAL_STRING_PROCESSINGdisabled doesn't pass the flag to implicitly disable the module import, but when building the stdlib modules on said configurations, the compiler will try to link them against string processing because, well, it's an implicit import. Just always disable the implicit import for every stdlib module now.Resolves: rdar://106326062 & rdar://106374161