[Macros] Add OptionSet and plumb it through #64091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test |
3 similar comments
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test |
My, how the language has grown.
DougGregor
force-pushed
the
option-set-macro
branch
from
477d418 to
af6fe8b
Compare
Member
Author
|
@swift-ci please smoke test |
hborla
reviewed
Mar 4, 2023
| /// case standard | ||
| /// } | ||
| /// } | ||
| @attached(member) |
Member
There was a problem hiding this comment.
Suggested change
| @attached(member) | |
| @attached(member, names: named(RawValue), named(rawValue), named(`init`), arbitrary) |
Member
|
@swift-ci please test |
bnbarham
added a commit
to bnbarham/swift
that referenced
this pull request
Mar 5, 2023
…-macro" This reverts commit 2979ed5, reversing changes made to 1c86433. Causes failures on `validation-test/SIL/parse_stdlib.sil` when parsing `OptionSet.init`, presumably because name lookup now finds the macro as well: ``` %10 = witness_method $Self, #OptionSet.init!allocator : <Self where Self : OptionSet> (Self.Type) -> (Self.RawValue) -> Self : $@convention(witness_method: OptionSet) <τ_0_0 where τ_0_0 : OptionSet> (@in τ_0_0.RawValue, @thick τ_0_0.Type) -> @out τ_0_0 // user: %11 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.