Add a Macros chapter #137
Merged
Add a Macros chapter #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporates tech review from Doug Gregor <[email protected]>.
Per discussion with Chuck Toporek <[email protected]>.
Includes feedback from Chuck Toporek <[email protected]>.
Assets from rdar://108348114
chuckdude
requested changes
May 12, 2023
Contributor
chuckdude
left a comment
chuckdude
left a comment
There was a problem hiding this comment.
Provided edits and queries throughout. Overall, this is in good shape; mostly minor edits and typo fixes. Please let me know if you'd like to discuss the reorg proposed in the "Macro Declarations" section.
chuckdude
requested changes
May 12, 2023
Contributor
chuckdude
left a comment
chuckdude
left a comment
There was a problem hiding this comment.
Provided edits and queries throughout. Overall, this is in good shape; mostly minor edits and typo fixes. Please let me know if you'd like to discuss the reorg proposed in the "Macro Declarations" section.
Incorporates feedback from Doug Gregor <[email protected]>. Assets from <rdar://109134519>.
Assets from <rdar://109134519>.
- Add alt text to new figures. - Introduce macro roles earlier. - Expand discussion of the AST. Incorporates edits from Chuck Toporek <[email protected]>.
Incorporates edits from Chuck Toporek <[email protected]>.
Incorporates feedback from Chuck Toporek <[email protected]>.
chuckdude
approved these changes
May 30, 2023
Contributor
chuckdude
left a comment
chuckdude
left a comment
There was a problem hiding this comment.
Reviewed changes and revisions w/Alex via email. Approving this PR.
amartini51
force-pushed
the
release/5.9_beta_1
branch
from
f4144f9 to
d0bae5b
Compare
I've reached out to engineering about the TR markers; what's left doesn't need to block shipping the initial version of this chapter.
Incorporates review from Brian Lanier <[email protected]>.
bjlanier
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pitch thread: https://forums.swift.org/t/64339
Built preview: https://amartini51.github.io/swift-book/documentation/the-swift-programming-language/macros/
Fixes: rdar://107494884