[Dependency Scanning] Detect candidate files for .private interface files also
#63735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkcsgexi
approved these changes
Feb 17, 2023
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
PrivatePeerCandidateDiscovery
branch
from
db62258 to
6b13bf0
Compare
Contributor
Author
|
@swift-ci test |
artemcm
force-pushed
the
PrivatePeerCandidateDiscovery
branch
from
6b13bf0 to
6d59868
Compare
Contributor
Author
1 similar comment
Contributor
Author
Contributor
Author
|
swiftlang/swift-driver#1282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic assumed we don't have the
.private.in the interface name and looked for an adjacent binary module with.private.swiftmodule, which we do not produce. So also try stripping off the.private.and do a lookup.