[Explicit Module Builds] Rely on the dependency scanner to produce complete compile commands for Swift dependencies #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We should wait a fair bit to merge this, at least until swiftlang/swift#63460 makes it to a toolchain snapshot picked up by CI. |
artemcm
force-pushed
the
SelfContainedExplicitSwiftDeps
branch
from
90bb63e to
5bb1359
Compare
artemcm
force-pushed
the
SelfContainedExplicitSwiftDeps
branch
from
5bb1359 to
22d0173
Compare
Contributor
Author
|
swiftlang/swift#63460 has made it to a nightly toolchain. ( |
Contributor
Author
|
@swift-ci test |
…mplete compile commands for Swift dependencies This change removes instances where the driver modified command-line invocations used to build Swift module dependencies, as produced by the dependency scanner. Instead, the scanner will now emit command lines that are sufficient to build all such module dependencies, including explicit dependency inputs.
artemcm
force-pushed
the
SelfContainedExplicitSwiftDeps
branch
from
22d0173 to
c643884
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
Not to be merged until swiftlang/swift#63697 lands, otherwise Explicit Modules functionality will be limited. |
nkcsgexi
approved these changes
Feb 21, 2023
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes instances where the driver modified command-line invocations used to build Swift module dependencies, as produced by the dependency scanner. Instead, the scanner will now emit command line argument sets that are sufficient to build all such module dependencies out-of-the-box, including explicit dependency inputs.
The scanner adopts (swiftlang/swift#63460) newly-(re-)added
-swift-module-fileto specify explicit Swift interface dependencies' explicit dependencies. The driver continues using-explicit-swift-module-map-fileJSON file input to specify all explicit dependencies for the main module's compilation commands (emit-module, compile, etc.), furthermore moving prebuilt Clang dependencies to also appear in this file, thanks to @allevato's change in swiftlang/swift#63178.