Support cross compilation of docc in macOS toolchain builds
#62306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the build script used in SwiftCI for building the `docc` executable as part of Swift.org toolchains to support cross compilation. Currently the `docc` executable included in the otherwise universal macOS toolchain only supports x86_64. This resolves the issue.
Contributor
Author
|
swiftlang/swift-docc#434 |
1 similar comment
Contributor
Author
|
swiftlang/swift-docc#434 |
Contributor
Author
|
This seems to resolve the issue: |
Contributor
Author
|
swiftlang/swift-docc#434 |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
swiftlang/swift-docc#434 |
Contributor
Author
|
swiftlang/swift-docc#434 |
Contributor
Author
|
swiftlang/swift-docc#434 |
Contributor
Author
|
swiftlang/swift-docc#434 |
Contributor
Author
|
swiftlang/swift-docc#434 |
shahmishal
approved these changes
Dec 1, 2022
d-ronnqvist
approved these changes
Dec 1, 2022
ethan-kusters
added a commit
to ethan-kusters/swift
that referenced
this pull request
Dec 2, 2022
…g#62306)" This reverts commit a36ab6e. The change to support cross compilation of `docc` in macOS toolchains is breaking nightly toolchain builds – this will unblock them. It looks like the `--test-product` option Swift-DocC's build script passes to SwiftPM is supported when building for multiple architectures but not when testing. PR toolchain builds don't run tests which is why this wasn't caught before merging. Resolves rdar://102908495
shahmishal
pushed a commit
that referenced
this pull request
Dec 2, 2022
…#62369) This reverts commit a36ab6e. The change to support cross compilation of `docc` in macOS toolchains is breaking nightly toolchain builds – this will unblock them. It looks like the `--test-product` option Swift-DocC's build script passes to SwiftPM is supported when building for multiple architectures but not when testing. PR toolchain builds don't run tests which is why this wasn't caught before merging. Resolves rdar://102908495
ethan-kusters
added a commit
to ethan-kusters/swift
that referenced
this pull request
Jan 17, 2023
…wiftlang#62306)"" This reverts commit c57f491.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves swiftlang/swift-docc#433.
Updates the build script used in SwiftCI for building the
doccexecutable as part of Swift.org toolchains to support cross compilation.Currently the
doccexecutable included in the otherwise universal macOS toolchain only supports x86_64. This resolves the issue.