Support cross compilation in macOS toolchain builds #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the build script used in SwiftCI for building the `docc` executable as part of Swift.org toolchains to support cross compilation. Currently the `docc` executable included in the otherwise universal macOS toolchain only supports x86_64. This resolves the issue.
The bin path is different when building for multiple architectures so we need to pass the complete swiftpm args we use during a full build when requesting the bin path instead of a custom set.
ethan-kusters
requested review from
d-ronnqvist,
daniel-grumberg,
neonichu and
shahmishal
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
The macOS toolchain attached to swiftlang/swift#62306 now includes a universal |
neonichu
approved these changes
Nov 30, 2022
Contributor
Author
|
@swift-ci please test |
shahmishal
approved these changes
Dec 1, 2022
d-ronnqvist
approved these changes
Dec 1, 2022
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: closes #433
Summary
Updates the build script used in SwiftCI for building the
doccexecutable as part of Swift.org toolchains to support cross compilation.Currently the
doccexecutable included in the otherwise universal macOS toolchain only supports x86_64. This resolves the issue.