Skip to content

Revert "IRGen: Co-locate metadata instatiation/completions/accessor functions in a special section" #62203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2022
Merged

Revert "IRGen: Co-locate metadata instatiation/completions/accessor functions in a special section" #62203

merged 1 commit into from
Nov 19, 2022

Conversation

@shahmishal
Copy link
Member

@shahmishal shahmishal commented Nov 19, 2022 •
edited
Loading

Reverts #61984

We are seeing 20 lldb test failures only on aarch64.

Failed Tests (20):
  lldb-api :: lang/swift/closure_shortcuts/TestClosureShortcuts.py
  lldb-api :: lang/swift/cxx_interop/forward/test-cxx-class/TestCxxClass.py
  lldb-api :: lang/swift/expression/basic/TestSwiftBasicExpression.py
  lldb-api :: lang/swift/expression/simple/TestSimpleExpressions.py
  lldb-api :: lang/swift/fixits/TestSwiftFixIts.py
  lldb-api :: lang/swift/po/ref_types/TestSwiftPORefTypes.py
  lldb-api :: lang/swift/po/val_types/TestSwiftPOValTypes.py
  lldb-api :: lang/swift/printdecl/TestSwiftTypeLookup.py
  lldb-api :: lang/swift/regex/TestSwiftRegex.py
  lldb-api :: lang/swift/variables/dictionary/TestSwiftStdlibDictionary.py
  lldb-api :: lang/swift/variables/generic_struct_debug_info/generic_array/TestSwiftGenericStructDebugInfoGenericArray.py
  lldb-api :: lang/swift/variables/generic_struct_debug_info/generic_flatmap/TestSwiftGenericStructDebugInfoGenericFlatMap.py
  lldb-shell :: SwiftREPL/ClosureScope.test
  lldb-shell :: SwiftREPL/Dict.test
  lldb-shell :: SwiftREPL/ErrorReturn.test
  lldb-shell :: SwiftREPL/GenericTypealias.test
  lldb-shell :: SwiftREPL/Generics.test
  lldb-shell :: SwiftREPL/LookupAfterImport.test
  lldb-shell :: SwiftREPL/MetatypeRepl.test
  lldb-shell :: SwiftREPL/SimpleExpressions.test

@shahmishal shahmishal merged commit 1f3e159 into main Nov 19, 2022
@shahmishal shahmishal deleted the revert-61984-colocate_instantiation branch November 19, 2022 07:46
aschwaighofer added a commit to aschwaighofer/swift that referenced this pull request Nov 28, 2022
@aschwaighofer
Revert "Merge pull request swiftlang#62203 from apple/revert-61984-co…
082349e 
…locate_instantiation"

This reverts commit 1f3e159, reversing
changes made to 103b4a8.

Re-applies "IRGen: Co-locate metadata instatiation/completions/accessor
functions in a special section" for MachO only. The original change broke lldb
on aarch64 linux.

rdar://102481054
aschwaighofer added a commit that referenced this pull request Nov 29, 2022
@aschwaighofer
Merge pull request #62275 from aschwaighofer/rdar102481054
3617b76 
Revert "Merge pull request #62203 from apple/revert-61984-colocate_in…
aschwaighofer added a commit that referenced this pull request Nov 29, 2022
@aschwaighofer
Revert "Revert "Merge pull request #62203 from apple/revert-61984-col…
ea3d9a1 
…ocate_in…"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aschwaighofer aschwaighofer Awaiting requested review from aschwaighofer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shahmishal