IRGen: Co-locate metadata instatiation/completions/accessor functions in a special section #61984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
compnerd
reviewed
Nov 10, 2022
lib/IRGen/GenDecl.cpp
Outdated
Member
There was a problem hiding this comment.
Do we intend to need to create a linker table for this data? The grouping ($B) is for cases where we need to order the data in between start/stop markers to allow the table computation. If so, we should probably have an associated set of changes to SwiftRT-ELF.cpp and SwiftRT-COFF.cpp.
Contributor
Author
There was a problem hiding this comment.
No. I just copied the string from further up the file.
Member
There was a problem hiding this comment.
In that case, this should probably be named .sw5colo.
… in a special section For spatial locality on startup. rdar://101593202
Credit to Lang Hames who identified the fix.
aschwaighofer
force-pushed
the
colocate_instantiation
branch
from
57a2b6a to
4718c23
Compare
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test source compat |
1 similar comment
Contributor
Author
|
@swift-ci test source compat |
Contributor
Author
|
@swift-ci test source compat release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For spatial locality on startup.
rdar://101593202