Skip to content

[CodeCompletion] Migrate some tests to batch completion test #4 #36725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2021
Merged

[CodeCompletion] Migrate some tests to batch completion test #4 #36725

merged 1 commit into from
Apr 2, 2021

Conversation

@rintaro
Copy link
Member

@rintaro rintaro commented Apr 2, 2021 •
edited
Loading 

21.05s: Swift(macosx-x86_64) :: IDE/complete_call_arg.swift
10.04s: Swift(macosx-x86_64) :: IDE/complete_where_clause.swift
9.82s: Swift(macosx-x86_64) :: IDE/complete_from_stdlib.swift
9.60s: Swift(macosx-x86_64) :: IDE/complete_constructor.swift
8.98s: Swift(macosx-x86_64) :: IDE/complete_enum_elements.swift
7.78s: Swift(macosx-x86_64) :: IDE/complete_value_literals.swift
0.53s: Swift(macosx-x86_64) :: IDE/complete_value_expr_call_pattern_heuristics.swift

to

1.44s: Swift(macosx-x86_64) :: IDE/complete_call_arg.swift
1.28s: Swift(macosx-x86_64) :: IDE/complete_from_stdlib.swift
0.80s: Swift(macosx-x86_64) :: IDE/complete_enum_elements.swift
0.78s: Swift(macosx-x86_64) :: IDE/complete_constructor.swift
0.48s: Swift(macosx-x86_64) :: IDE/complete_where_clause.swift
0.42s: Swift(macosx-x86_64) :: IDE/complete_value_literals.swift
0.25s: Swift(macosx-x86_64) :: IDE/complete_call_pattern_heuristics.swift

see also:
#36714 #36715 #36716

@rintaro rintaro force-pushed the ide-completion-batchtest4 branch from 5a6fa9e to 9c5e118 Compare April 2, 2021 17:14
rintaro
rintaro commented Apr 2, 2021
View reviewed changes
@rintaro
Copy link
Member Author

rintaro commented Apr 2, 2021

@swift-ci Please smoke test

@rintaro rintaro requested a review from benlangmuir April 2, 2021 18:11
@rintaro
Copy link
Member Author

rintaro commented Apr 2, 2021

@swift-ci Please smoke test Windows

benlangmuir
benlangmuir approved these changes Apr 2, 2021
View reviewed changes
@rintaro rintaro force-pushed the ide-completion-batchtest4 branch from 9c5e118 to b810bb7 Compare April 2, 2021 18:50
@rintaro
Copy link
Member Author

rintaro commented Apr 2, 2021

@swift-ci Please smoke test

@rintaro rintaro merged commit f6cd99e into swiftlang:main Apr 2, 2021
@rintaro rintaro deleted the ide-completion-batchtest4 branch April 2, 2021 22:19
@atrick
Copy link
Contributor

atrick commented Apr 3, 2021

@rintaro PR testing is blocked on this failure because this was only smoke tested
Swift(iphonesimulator-x86_64).IDE.complete_where_clause.swift

Should this be an XFAIL or PR revert?

@tkremenek
Copy link
Member

tkremenek commented Apr 3, 2021

This PR should be reverted. Reverting.

@tkremenek tkremenek mentioned this pull request Apr 3, 2021
Merged
@rintaro rintaro mentioned this pull request Apr 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rintaro @atrick @tkremenek @benlangmuir