Skip to content

[CodeCompletion] Migrate some tests to batch completion test #3 #36716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2021
Merged

[CodeCompletion] Migrate some tests to batch completion test #3 #36716

merged 1 commit into from
Apr 2, 2021

Conversation

@rintaro
Copy link
Member

@rintaro rintaro commented Apr 2, 2021 

17.59s: Swift(macosx-x86_64) :: IDE/complete_type_in_func_param.swift
15.08s: Swift(macosx-x86_64) :: IDE/complete_keywords.swift
14.37s: Swift(macosx-x86_64) :: IDE/complete_sself.swift
12.97s: Swift(macosx-x86_64) :: IDE/complete_in_closures.swift
9.85s: Swift(macosx-x86_64) :: IDE/complete_pattern.swift
9.65s: Swift(macosx-x86_64) :: IDE/complete_single_expression_return.swift

to

1.18s: Swift(macosx-x86_64) :: IDE/complete_in_closures.swift
0.95s: Swift(macosx-x86_64) :: IDE/complete_keywords.swift
0.69s: Swift(macosx-x86_64) :: IDE/complete_sself.swift
0.66s: Swift(macosx-x86_64) :: IDE/complete_type_in_func_param.swift
0.56s: Swift(macosx-x86_64) :: IDE/complete_single_expression_return.swift
0.52s: Swift(macosx-x86_64) :: IDE/complete_pattern.swift

@rintaro
Copy link
Member Author

rintaro commented Apr 2, 2021

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Apr 2, 2021 •
edited
Loading

@bnbarham This set was easy. Pure script migration 👍

@rintaro rintaro requested a review from bnbarham April 2, 2021 05:35
@rintaro
Copy link
Member Author

rintaro commented Apr 2, 2021

@swift-ci Please smoke test

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Apr 2, 2021

@swift-ci Please smoke test

@rintaro rintaro mentioned this pull request Apr 2, 2021
Merged
@rintaro
Copy link
Member Author

rintaro commented Apr 2, 2021

@swift-ci Please smoke test macOS

@rintaro rintaro merged commit d8d4fc9 into swiftlang:main Apr 2, 2021
@rintaro rintaro deleted the ide-completion-batchtest3 branch April 2, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rintaro @bnbarham