Skip to content

[5.3][CodeCompletion] Don't update VFS content hash map after each completion #33648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2020
Merged

[5.3][CodeCompletion] Don't update VFS content hash map after each completion #33648

merged 1 commit into from
Aug 26, 2020

Conversation

@rintaro
Copy link
Member

@rintaro rintaro commented Aug 26, 2020 •
edited
Loading

Cherry-pick of #33645 into release/5.3

  • Explanation: Fix an issue where stat is call on all the dependency files for each completion invocation. There was a function call that checks the files are from virtual file systems. It was completely unnecessary to do it after each fast-completion.
  • Scope: Code completion
  • Risk: Low
  • Testing: There's no observable behavior change. A regression test case is updated to ensure that it behaves correctly.
  • Issue: rdar://problem/67773257
  • Reviewer: Ben Langmuir (@benlangmuir)

@rintaro
[CodeCompletion] Don't update VFS content hash map after each completion
ef8f05a 
This was not needed. The list of depenencies should not be changed
during fast-completion sessions.

This was also harmful because it calls stat(2) for all the dependency
files.

rdar://problem/67773257
(cherry picked from commit bf5fb4d)
@rintaro rintaro added the r5.3 label Aug 26, 2020
@rintaro rintaro requested a review from a team as a code owner August 26, 2020 18:35
@rintaro
Copy link
Member Author

rintaro commented Aug 26, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 26, 2020

Build failed
Swift Test OS X Platform
Git Sha - ef8f05a

@rintaro
Copy link
Member Author

rintaro commented Aug 26, 2020

@swift-ci Please test macOS

@rintaro
Copy link
Member Author

rintaro commented Aug 26, 2020

@swift-ci Please nominate

@rintaro rintaro merged commit 7ef6d7a into swiftlang:release/5.3 Aug 26, 2020
@rintaro rintaro deleted the 5.3-ide-completion-rdar67773257 branch August 26, 2020 21:28
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

Assignees

No one assigned

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 5.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rintaro @swift-ci @akyrtzi @AnthonyLatsis