[CodeCompletion] Don't update VFS content hash map after each completion #33645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not needed. The list of depenencies should not be changed during fast-completion sessions. This was also harmful because it calls stat(2) for all the dependency files. rdar://problem/67773257
Member
Author
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not needed. The list of dependencies should not be changed during fast-completion sessions.
This was also harmful because it calls stat(2) for all the dependency files.
rdar://problem/67773257
(The updated test passes even without this change. Just to make sure it works correctly)