[AutoDiff] Enable differentiable programming by default for testing. #31189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build-script driver argument for differentiable programming is already enabled by default, for testing purposes. This makes macOS and Linux CI run AutoDiff tests. Now, the CMake flag for differentiable programming is also enabled by default. This makes Windows CI run AutoDiff tests as well. As before, compiler invocations that do not use differentiable programming features should not be affected.
|
@swift-ci Please smoke test |
|
An AutoDiff test failed on Windows, as expected: Fixed in #31201. |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows |
|
Re-running to see latest Windows failures. |
|
Right now, I'm seeing these two failures that are yet unresolved: Both of these are due to the runtime not finding conformance not being found for the types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build-scriptdriver argument for differentiable programming is alreadyenabled by default, for testing purposes. This makes macOS and Linux CI run
AutoDiff tests.
Now, the CMake flag for differentiable programming is also enabled.
This should make Windows CI run AutoDiff tests as well.
As before, compiler invocations that do not use differentiable programming
features should not be affected.
Let's confirm that AutoDiff tests pass on Windows CI before merging.
AutoDiff test failures on Windows are expected, so we should fix those first.