[Type checker] Requestify type checking of a function body #26131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass. This is more a matter of principle than an optimization, eliminating unnecessary calls to `AbstractFunctionDecl::setBody()`.
When the parser wires up the body of a function, it's a legitimate use of setting a parsed body. Separate these out from the other uses of setBody() that we want to eliminate over time.
…il(). These three functions shared a bunch of code in common. Fuse them into their only caller, typeCheckAbstractFunctionBodyUntil() and centralize the point at which we set the body of the function.
… special Instead of being a completely separate body type-checking pass, refactor this function so it does the function builder transform on the body, then continues with the rest of typeCheckFunctionBodyUntil() as normal.
Extend the "type check function body" request to also cover the case where we have a specific ending source location. Fold all of this functionality into a single request, so we consistently go through a request to compute a type-checked function body.
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please test source compatibility |
slavapestov
reviewed
Jul 13, 2019
| void dump(const SourceManager &SM) const; | ||
|
|
||
| friend size_t hash_value(SourceLoc loc) { | ||
| return reinterpret_cast<uintptr_t>(loc.getOpaquePointerValue()); |
Contributor
There was a problem hiding this comment.
Weird indentation here
Member
Author
There was a problem hiding this comment.
Huh, tabs. I'll clean it up, thanks!
DougGregor
changed the title
Member
Author
|
@swift-ci please smoke test Linux |
Member
Author
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fully requestify the type checking of a function body, so it covers all uses of "type check a function body (up to a certain point)" in the request. While here, make a few more synthesized bodies lazy: