Lazily synthesize yet more function bodies #26114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass. This is more a matter of principle than an optimization, eliminating unnecessary calls to `AbstractFunctionDecl::setBody()`.
Member
Author
|
@swift-ci please smoke test and merge |
When the parser wires up the body of a function, it's a legitimate use of setting a parsed body. Separate these out from the other uses of setBody() that we want to eliminate over time.
Member
Author
|
Whoops, that second commit is bogus. Working on a fix. |
DougGregor
force-pushed
the
yet-more-lazy-function-bodies
branch
from
e8a3af7 to
753322c
Compare
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
Obsoleted by #26131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy synthesis for a few simple cases that likely don't matter for performance, but are nonetheless nice to get away from ad hoc mutation of function bodies: