[Coverage] Mark symtab entries as guaranteed after intrinsic lowering #16610
Conversation
SIL optimizations may rewrite profiling intrinsics in a way that IRGen can't lower (r://39146527). Don't claim that a coverage mapping has a guaranteed associated symbol table entry when this happens. I have not added a test, as this is a defensive workaround until we can land add a SIL verifier check that prevents profiling intrinsics from being rewritten. rdar://40133800 (cherry picked from commit bdfd220) (cherry picked from commit b74abea)
This adds SIL printer/parser support for SILCoverageMaps representing top-level code decls. (cherry picked from commit e7b55a1)
This adds a test case to exercise a path in IRGen which discards ill-formed profiling intrinsics. rdar://40133800 & r://39146527 (cherry picked from commit 39194a8)
|
@swift-ci Please test |
dcci
left a comment
dcci
left a comment
There was a problem hiding this comment.
This looks fine as a temporary workaround.
|
@swift-ci please nominate |
2 participants
SIL optimizations may rewrite profiling intrinsics in a way that IRGen
can't lower (r://39146527). Don't claim that a coverage mapping has a
guaranteed associated symbol table entry when this happens.
rdar://40133800