[Coverage] Test lowering of ill-formed SIL profiling intrinsics #16607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
Hi @shajrawi & @slavapestov, could one of you please review this when you have a moment? |
Contributor
Author
|
(This is a follow-up to: #16522) |
This adds SIL printer/parser support for SILCoverageMaps representing top-level code decls.
This adds a test case to exercise a path in IRGen which discards ill-formed profiling intrinsics. rdar://40133800 & r://39146527
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci Please smoke test OS X platform |
Contributor
Author
|
Davide lgtm'd this in #16610. |
kitasuke
pushed a commit
to kitasuke/swift
that referenced
this pull request
Jun 9, 2018
…tlang#16607) * [Coverage] Parse SIL coverage maps for top-level code decls This adds SIL printer/parser support for SILCoverageMaps representing top-level code decls. * [Coverage] Test lowering of ill-formed SIL profiling intrinsics This adds a test case to exercise a path in IRGen which discards ill-formed profiling intrinsics. rdar://40133800 & r://39146527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case to exercise a path in IRGen which discards
ill-formed profiling intrinsics.
The reason that path exists is because SIL optimizations may rewrite profiling intrinsics in a way that IRGen can't understand. Essentially IRGen would need to undo the optimizations in order to gather information needed to emit the right LLVM IR.
Eventually I'd like to fix this by adding a SIL verifier check to make sure SIL optimizations don't touch profiling intrinsics (see: r://39146527), but we need to avoid generating incorrect binaries right away.
rdar://40133800