Skip to content

Remove temp_await [part 2] #7845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2024
Merged

Remove temp_await [part 2] #7845

merged 1 commit into from
Aug 2, 2024

Conversation

@AndrewHoos
Copy link
Contributor

@AndrewHoos AndrewHoos commented Aug 1, 2024 •
edited by MaxDesiatov
Loading

Remove usages of temp_await.

Motivation:

temp_await is unsafe and it would be better to use true async methods.

Modifications:

Replace 16 uses of temp_await with actual async methods.

Result:

Safer more modern Swift code.

@AndrewHoos
Copy link
Contributor Author

@swift-ci test

@AndrewHoos AndrewHoos changed the title Remove temp await [part 2] Remove temp_await [part 2] Aug 1, 2024
@AndrewHoos AndrewHoos force-pushed the deprecateTempAwait2 branch from 25821c7 to 5e955c6 Compare August 1, 2024 21:16
@AndrewHoos
Copy link
Contributor Author

@swift-ci test

@AndrewHoos AndrewHoos force-pushed the deprecateTempAwait2 branch 2 times, most recently from 43013a1 to 8aa92ec Compare August 1, 2024 23:27
@AndrewHoos
Copy link
Contributor Author

@swift-ci test

@AndrewHoos AndrewHoos enabled auto-merge (squash) August 2, 2024 00:49
@AndrewHoos AndrewHoos mentioned this pull request Aug 2, 2024
Merged
@AndrewHoos AndrewHoos force-pushed the deprecateTempAwait2 branch from 8aa92ec to e82e46c Compare August 2, 2024 04:29
@AndrewHoos
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

MaxDesiatov
MaxDesiatov requested changes Aug 2, 2024
View reviewed changes
@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

MaxDesiatov
MaxDesiatov reviewed Aug 2, 2024
View reviewed changes
MaxDesiatov
MaxDesiatov approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerns addressed in an offline conversation (points of feedback to be addressed in immediately following PRs).

Thanks!

@AndrewHoos AndrewHoos merged commit db98fad into main Aug 2, 2024
@AndrewHoos AndrewHoos deleted the deprecateTempAwait2 branch August 2, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis

@xedin xedin Awaiting requested review from xedin

Assignees

No one assigned

Labels

bug concurrency

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewHoos @MaxDesiatov