Adopt new async (but not yet swift 6) methods from SwiftPM #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Thank you. I would like to merge this close to the corresponding SwiftPM PR so we don't have a warning about a superfluous await in SourceKit-LSP for it for too long. Can you let me know when the SwiftPM PR is close to being merged and then I'll hit merge on this one. Until then you can test your SwiftPM changes with cross-PR testing.
|
@swift-ci testt |
AndrewHoos
force-pushed
the
asyncGraphLoading
branch
from
a66a4ff to
a516809
Compare
AndrewHoos
changed the title
MaxDesiatov
changed the title
|
@ahoppen looks like the corresponding PR landed: |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to make swift-package-manager loading async in swiftlang/swift-package-manager#7845. This PR preemptively adds the await will cause a warning before the async method is public.