Change Windows installation instructions

[libewa]

Motivation:

The Windows installation process errored out on my PC, complaining that start could not find the vs_community.exe file, which was however present after running ls.

Modifications:

• Change the installation code block for Windows to not use start, but instead execute the installer directly.
• Change the reference to the Microsoft Store from "App Store".

Result:

The installation instructions for Windows have changed to
a) not quit with an error
b) correctly reference the Microsoft Store

[alexandersandberg]

cc: @compnerd

[stevapple]

The Windows installation guide currently handles VS installation manually. We can leverage WinGet features instead:

winger install Microsoft.VisualStudio.2019.Community --force --custom "--add Microsoft.VisualStudio.Component.Windows10SDK.19041 --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64"

Breakdown:

• The Microsoft.VisualStudio.2019.Community installer is exactly the latest version of https://aka.ms/vs/16/release/vs_community.exe;
• --force ensures that the installer is run even when the latest VS is installed;
• --custom passes the supplied flags to the installer, which will add the dependencies for us.

Such approach is much less error-prone as WinGet already counts for different environments (most notably, Powershell or CMD).

[stevapple]

Also I feel that installing the community version of VS is a waste because Swift developers don't need the IDE stuff. Visual Studio C++ Build Tools (vs_buildtools.exe or Microsoft.VisualStudio.2019.BuildTools) is pretty enough.

[compnerd]

@libewa did you run from cmd or powershell/pwsh? The expectation is that you are using the cmd shell. For automation, the use of start is important.

@stevapple yes, winget is the easier solution. Especially now that winget is a stub on Windows 11 that auto installs. Perhaps we should swap the order and direct people to the winget instructions?

Also, you are correct that the build tools are sufficient but there are questions around licensing. VS Community is permitted for use for many cases. The build tools require a license of Visual Studio and thus the installation of VS. The instructions seem complicated enough so I think that we should keep to the Visual Studio installation.

[libewa]

@compnerd I used pscore7, maybe that's the problem, but I'm going on holiday and can't try any of the solutions.
@stevapple sounds good, as we are installing deps with winget anyways. we should maybe add a note that winget comes preinstalled on win11.

[libewa]

also, maybe we should actually use cmd syntax highlighting instead of pwsh

[compnerd]

I wonder if we should just move this to VS2022 at this point and update the SDK to the latest.

[libewa]

this is a story for another pr imo

[compnerd]

Similar

[compnerd]

LGTM

[alexandersandberg]

@swift-ci please test

[alexandersandberg]

@swift-ci please test