-
Notifications
You must be signed in to change notification settings - Fork 241
Change Windows installation instructions #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1fee379
change windows "app store" to microsoft store
libewa 3c92ce9
ditto
libewa 43930f1
remove start /w for windows
libewa 4b2f146
forgor to remove the actual start command
libewa c31b50b
install vs using winget when used, else use start
libewa 344e45e
we don't need no downloading the vs installer
libewa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,7 +69,7 @@ In order to develop applications, particularly with the Swift Package Manager, y | |
|
||
##### Install using the Windows Package Manager | ||
|
||
The [Windows Package Manager](https://docs.microsoft.com/windows/package-manager/) can be found in the [App Store](https://www.microsoft.com/en-us/p/app-installer/9nblggh4nns1) or be [installed directly](ms-appinstaller:?source=https://aka.ms/getwinget). | ||
The [Windows Package Manager](https://docs.microsoft.com/windows/package-manager/) can be found in the [Microsoft Store](https://www.microsoft.com/en-us/p/app-installer/9nblggh4nns1) or be [installed directly](ms-appinstaller:?source=https://aka.ms/getwinget). | ||
|
||
#### Install using Scoop | ||
|
||
|
@@ -82,32 +82,26 @@ Invoke-RestMethod -Url 'get.scoop.sh' | Invoke-Expression | |
|
||
0. Install required dependencies: | ||
|
||
The platform dependencies cannot be installed through the currently supported package managers as the install rules do not install the components necessary. They will be installed through Visual Studio installer. | ||
The platform dependencies cannot be installed through the currently supported package managers as the install rules do not install the components necessary. They will be installed through the Visual Studio installer. | ||
|
||
#### With Winget (Windows Package Manager): | ||
~~~ pwsh | ||
~~~ cmd | ||
winget install Git.Git | ||
winget install Python.Python.3.10 | ||
|
||
curl -sOL https://aka.ms/vs/16/release/vs_community.exe | ||
start /w vs_community.exe --passive --wait --norestart --nocache ^ | ||
--installPath "%ProgramFiles(x86)%\Microsoft Visual Studio\2019\Community" ^ | ||
--add Microsoft.VisualStudio.Component.Windows10SDK.19041 ^ | ||
--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 | ||
del /q vs_community.exe | ||
winget install Microsoft.VisualStudio.2019.Community --force --custom "--add Microsoft.VisualStudio.Component.Windows10SDK.19041 --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar |
||
~~~ | ||
|
||
#### With Scoop: | ||
~~~ pwsh | ||
> **NOTE:** This code snippet MUST be run in a traditional Command Prompt (`cmd.exe`) | ||
|
||
~~~ cmd | ||
# Scoop already comes pre-installed with Git, so no need to re-install it. | ||
scoop bucket add versions | ||
scoop install python310 | ||
|
||
curl -sOL https://aka.ms/vs/16/release/vs_community.exe | ||
start /w vs_community.exe --passive --wait --norestart --nocache ^ | ||
--installPath "%ProgramFiles(x86)%\Microsoft Visual Studio\2019\Community" ^ | ||
--add Microsoft.VisualStudio.Component.Windows10SDK.19041 ^ | ||
--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 | ||
start /w vs_community.exe --passive --wait --norestart --nocache --installPath "%ProgramFiles(x86)%\Microsoft Visual Studio\2019\Community" --add Microsoft.VisualStudio.Component.Windows10SDK.19041 --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 | ||
del /q vs_community.exe | ||
~~~ | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should just move this to VS2022 at this point and update the SDK to the latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a story for another pr imo