Skip to content

[5.10] Update swift-markdown and fix test case #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2023
Merged

[5.10] Update swift-markdown and fix test case #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80924f7
Update Package.swift to use release branch
Kyle-Ye Sep 21, 2023
96448c9
Update swift-markdown and fix test case
Kyle-Ye Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,10 @@ if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil {
// Building standalone, so fetch all dependencies remotely.
package.dependencies += [
.package(url: "https://github.com/apple/swift-nio.git", from: "2.53.0"),
.package(url: "https://github.com/apple/swift-markdown.git", branch: "main"),
.package(url: "https://github.com/apple/swift-lmdb.git", branch: "main"),
.package(url: "https://github.com/apple/swift-markdown.git", branch: "release/5.10"),
.package(url: "https://github.com/apple/swift-lmdb.git", branch: "release/5.10"),
.package(url: "https://github.com/apple/swift-argument-parser", from: "1.2.2"),
.package(url: "https://github.com/apple/swift-docc-symbolkit", branch: "main"),
.package(url: "https://github.com/apple/swift-docc-symbolkit", branch: "release/5.10"),
.package(url: "https://github.com/apple/swift-crypto.git", from: "2.5.0"),
.package(url: "https://github.com/apple/swift-docc-plugin", from: "1.2.0"),
]
Expand Down
6 changes: 3 additions & 3 deletions Tests/SwiftDocCTests/Infrastructure/DocumentationContext/DocumentationContextTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ class DocumentationContextTests: XCTestCase {
│ │ │ │ ├─ Argument text segments:
│ │ │ │ | "source: figure1.png, alt: figure1 "
│ │ │ ├─ Paragraph
│ │ │ │ └─ Image source: "figure1" title: ""
│ │ │ │ └─ Image source: "figure1"
│ │ │ ├─ Paragraph
│ │ │ │ └─ Image source: "images/figure1" title: ""
│ │ │ │ └─ Image source: "images/figure1"
│ │ │ └─ Paragraph
│ │ │ └─ Text "Quis auctor elit sed vulputate mi sit amet."
│ │ ├─ BlockDirective name: "Comment"
Expand Down Expand Up @@ -345,7 +345,7 @@ class DocumentationContextTests: XCTestCase {
│ │ │ ├─ Paragraph
│ │ │ │ └─ Text "Phasellus faucibus scelerisque eleifend donec pretium."
│ │ │ ├─ Paragraph
│ │ │ │ └─ Image source: "something.png" title: ""
│ │ │ │ └─ Image source: "something.png"
│ │ │ │ └─ Text "Diagram"
│ │ │ ├─ CodeBlock language: swift
│ │ │ │ let scene = ARSCNView()
Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftDocCTests/Model/DocumentationMarkupTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class DocumentationMarkupTests: XCTestCase {
Discussion content.
"""
let expected = """
Image source: "image.jpg" title: ""
Image source: "image.jpg"
└─ Text "Image title"
Text " Abstract."
"""
Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftDocCTests/Rendering/RenderContentCompilerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class RenderContentCompilerTests: XCTestCase {
├─ Paragraph
│ └─ Link destination: "doc:article2"
│ ├─ Text "Custom Image Content "
│ └─ Image source: "https://example.com/test.png" title: ""
│ └─ Image source: "https://example.com/test.png"
│ └─ Text "random image"
├─ Paragraph
│ └─ Link destination: "doc:UNRESOVLED"
Expand Down