Skip to content

Conversation

@Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Sep 21, 2023

Update Package.swift to use release branch + Cherry-pick of #708

Actually IMO the Package.swift update should be committed right after the release/5.10 is cut off. 😄

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Sep 25, 2023

What's your opinion on this cherry-pick PR? @franklinsch

If you have concern of the mix update in one PR, I'm also open to split them into 2 PR.

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Sep 26, 2023

The swift-docc CI will only pass after the swift-markdown PR is merged. So there will be around 20 min failing period for the upstream swift 5.10 toolchain.

Merge Plan:

  • Merge swift-markdown PR on 2023/9/26 23:00(GMT+8)
  • Trigger this PR's CI (~20min)
  • Merge this PR
    cc @franklinsch

@Kyle-Ye Kyle-Ye force-pushed the bugfix/kyle/ci-fix-5_10 branch from 6c34b3b to 96448c9 Compare September 26, 2023 15:04
@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Sep 26, 2023

@swift-ci please test

@Kyle-Ye Kyle-Ye merged commit 72707e4 into swiftlang:release/5.10 Sep 26, 2023
@Kyle-Ye Kyle-Ye deleted the bugfix/kyle/ci-fix-5_10 branch September 26, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants