Navigator index multi-language render JSON support #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-kusters
approved these changes
Oct 29, 2021
Contributor
|
@swift-ci please test this |
jackhl
reviewed
Oct 31, 2021
jackhl
reviewed
Oct 31, 2021
jackhl
reviewed
Oct 31, 2021
Contributor
Author
|
@swift-ci please test |
jackhl
approved these changes
Nov 1, 2021
Adds support for the navigator index to process render JSON that contains variant overrides by applying patches for the languages in which the page is available. rdar://83398083
franklinsch
force-pushed
the
navigator-index-variants
branch
from
2cb2c98 to
350c05d
Compare
Contributor
Author
|
@swift-ci please test |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://83398083
Summary
Adds support for the navigator index to process render JSON that contains variant overrides by applying patches for the languages in which the page is available.
Note: the first commit adds the support and second commit fixes a typo
Dependencies
None.
Testing
Verify that when building a navigator index that contains multi-language render JSON, the content gets curated under each language tree.
Checklist
./bin/testscript and it succeeded