[5.9-05012023] Fix scrolling QuickSearch previews on iPad #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dobromir-hristov
commented
May 10, 2023
dobromir-hristov
commented
- Explanation: Fixes the QuickNav Preview scrolling issue on iPad, by adding exclusion zones to the scroll-locking.
- Scope: Docs pages with QuickNav on iPad
- Issue: rdar://108269711
- Risk: Small
- Testing: Added/updated unit tests and manually tested iPad
- Reviewer: @mportiz08
- Original PR: Fix QuickNav Preview scrolling issue on iOS mobile device #638
added 2 commits
May 10, 2023 10:34
franklinsch
approved these changes
May 11, 2023
…711-add-scroll-lock-exclusion
Contributor
Author
|
@swift-ci test |
dobromir-hristov
deleted the
release/5.9-05012023-r108269711-add-scroll-lock-exclusion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.