Skip to content

Conversation

@dobromir-hristov
Copy link
Contributor

Bug/issue #, if applicable: 108269711

Summary

Fixes the QuickNav Preview scrolling issue on iPad, by adding exclusion zones to the scroll-locking.

This should be carefully merged with #634

Dependencies

NA

Testing

  1. Open the app on iPad and then toggle QuickNav
  2. Search for something vague, so you can see a scroll area for the content and suggestions
  3. Assert you can scroll both while the background is still not scrollable.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

Copy link
Member

@marinaaisa marinaaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS simulator and it looks great! thanks for working on it. I'll close #635 in favor of this other implementation!

@mportiz08
Copy link
Contributor

mportiz08 commented May 4, 2023

This should be carefully merged with #634

Does it depend on that PR to work or are you just calling that out since they're so closely related? Just checking.

Copy link
Contributor

@mportiz08 mportiz08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me in the simulator, and I'll be able to more easily test on a real device tomorrow.

@dobromir-hristov
Copy link
Contributor Author

Does it depend on that PR to work or are you just calling that out since they're so closely related? Just checking.

That PR just moves the scrollable area to another element, so the data attribute would have to be moved there too.

@dobromir-hristov dobromir-hristov requested a review from hqhhuang May 5, 2023 07:00
@dobromir-hristov
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@mportiz08 mportiz08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working well for me on the actual device.

@dobromir-hristov
Copy link
Contributor Author

@swift-ci test

@dobromir-hristov dobromir-hristov merged commit d0d2b33 into swiftlang:main May 8, 2023
@dobromir-hristov dobromir-hristov deleted the dhristov/r108269711-add-scroll-lock-exclusion branch May 8, 2023 06:22
dobromir-hristov pushed a commit to dobromir-hristov/swift-docc-render that referenced this pull request May 8, 2023
dobromir-hristov pushed a commit to dobromir-hristov/swift-docc-render that referenced this pull request May 10, 2023
dobromir-hristov pushed a commit that referenced this pull request May 11, 2023
* Fix QuickNav Preview scrolling issue on iOS mobile device (#638)

resolves rdar://108269711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants