-
Notifications
You must be signed in to change notification settings - Fork 66
Fix QuickNav Preview scrolling issue on iOS mobile device #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix QuickNav Preview scrolling issue on iOS mobile device #638
Conversation
marinaaisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on iOS simulator and it looks great! thanks for working on it. I'll close #635 in favor of this other implementation!
Does it depend on that PR to work or are you just calling that out since they're so closely related? Just checking. |
mportiz08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well for me in the simulator, and I'll be able to more easily test on a real device tomorrow.
That PR just moves the scrollable area to another element, so the |
|
@swift-ci test |
mportiz08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working well for me on the actual device.
|
@swift-ci test |
* Fix QuickNav Preview scrolling issue on iOS mobile device (#638) resolves rdar://108269711
Bug/issue #, if applicable: 108269711
Summary
Fixes the QuickNav Preview scrolling issue on iPad, by adding exclusion zones to the scroll-locking.
This should be carefully merged with #634
Dependencies
NA
Testing
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded