Skip to content

[5.9] Render all attributes for Swift symbol declarations on a single line #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2023
Merged

[5.9] Render all attributes for Swift symbol declarations on a single line #641

merged 2 commits into from
May 9, 2023

Conversation

@mportiz08
Copy link
Contributor

@mportiz08 mportiz08 commented May 5, 2023

  • Explanation: Improves Swift declaration formatting by rendering all attributes on their own line
  • Scope: Small targeted JS change that runs for every Swift decl
  • Issue: rdar://108798969
  • Risk: Medium, small change but impacts all Swift decls
  • Testing: Added/updated unit tests and manually tested various kinds of declarations with attributes to look for any obvious regressions in formatting
  • Reviewer: @dobromir-hristov
  • Original PR: Render all attributes for Swift symbol declarations on a single line #633

@mportiz08
Render all attributes for Swift symbol declarations on a single line (s…
cfb9db3 
…wiftlang#633)

A previous change was made so that each attribute was broken onto its
own line, but this attempts to collapse all attributes onto their own
single line.

Example:

```swift
// before
@discardableResult @objc(bar) func foo() -> Int

// after
@discardableResult @objc(bar)
func foo() -> Int
```

Resolves: rdar://108798969
@mportiz08 mportiz08 requested a review from franklinsch May 5, 2023 17:31
@mportiz08
Copy link
Contributor Author

mportiz08 commented May 9, 2023

@swift-ci test

@mportiz08 mportiz08 merged commit 172d529 into swiftlang:release/5.9 May 9, 2023
@mportiz08 mportiz08 deleted the 5.9/render-all-attributes-on-one-line branch May 9, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mportiz08 @franklinsch