Render all attributes for Swift symbol declarations on a single line #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change was made so that each attribute was broken onto its own line, but this attempts to collapse all attributes onto their own single line. Example: ```swift // before @discardableResult @objc(bar) func foo() -> Int // after @discardableResult @objc(bar) func foo() -> Int ```
Assertions are now made on the actual formatted text for better accuracy and improved readability.
mportiz08
requested review from
dobromir-hristov,
ethan-kusters,
hqhhuang and
marinaaisa
hqhhuang
reviewed
May 4, 2023
3 tasks
dobromir-hristov
approved these changes
May 5, 2023
Contributor
dobromir-hristov
left a comment
dobromir-hristov
left a comment
There was a problem hiding this comment.
Changes look good, left minor suggestion.
Assertions are MUCH better. Thank you 🙇
src/components/DocumentationTopic/PrimaryContent/DeclarationSource.vue
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@swift-ci test |
mportiz08
added a commit
to mportiz08/swift-docc-render
that referenced
this pull request
May 5, 2023
…wiftlang#633) A previous change was made so that each attribute was broken onto its own line, but this attempts to collapse all attributes onto their own single line. Example: ```swift // before @discardableResult @objc(bar) func foo() -> Int // after @discardableResult @objc(bar) func foo() -> Int ``` Resolves: rdar://108798969
mportiz08
added a commit
that referenced
this pull request
May 9, 2023
…633) (#641) A previous change was made so that each attribute was broken onto its own line, but this attempts to collapse all attributes onto their own single line. Example: ```swift // before @discardableResult @objc(bar) func foo() -> Int // after @discardableResult @objc(bar) func foo() -> Int ``` Resolves: rdar://108798969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 108798969
Summary
This changes the behavior introduced with #618 to render all attributes on a single line as opposed to each one getting its own line.
Example:
Testing
Same testing instructions as #618 but verify that attributes are now all on one line as opposed to each getting their own line.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded