[XCTestCase] Output "test passed" #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a regression introduced in swiftlang#33 that causes the "test passed" message to never be output. Add a test to prevent future regressions.
Contributor
|
Thanks for catching this and cleaning up after me @modocache! Big 👍 for the test coverage. |
Contributor
Author
|
@briancroom My pleasure! Thanks for fighting the good fight to get rid of those globals 💪 |
mike-ferris
pushed a commit
that referenced
this pull request
Jan 13, 2016
[XCTestCase] Output "test passed"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression introduced in #33 that causes the "test passed"
message to never be output. Add a test to prevent future regressions.