Refactor to rely less on global state for failure reporting #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also allows removing a weird public method from XCTestCase
mike-ferris
pushed a commit
that referenced
this pull request
Jan 11, 2016
Refactor to rely less on global state for failure reporting
Contributor
There was a problem hiding this comment.
I believe this is a regression that causes "passed" to never be output.
Before, the following line appeared outside of the XCTCurrentFailures loop:
print("Test Case '\(method)' \(result) (\(printableStringForTimeInterval(duration)) seconds).")Now, it appears within the failures for loop. As a result, only the results of failing tests are printed.
modocache
added a commit
to modocache/swift-corelibs-xctest
that referenced
this pull request
Jan 12, 2016
Fix a regression introduced in swiftlang#33 that causes the "test passed" message to never be output. Add a test to prevent future regressions.
modocache
added a commit
to modocache/swift-corelibs-xctest
that referenced
this pull request
Jan 13, 2016
swiftlang#33 introduced another regression that was not fixed in 4944003: the total number of test runs was not being reported correctly--only the total number of failures. Fix the misreporting, as well as the incorrect verification in the `FailingTestSuite` functional test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally a piece of #27 but it makes sense to apply standalone.