SR-6403: NSURLRequest: implement description and add tests
#1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
|
LGTM |
Contributor
|
@swift-ci please test and merge |
Contributor
|
@ianpartridge these have conflicts with the normalisation tests that you wrote and were merged. Can you rebase these onto master and resubmit? |
ianpartridge
force-pushed
the
urlrequest-description
branch
from
e5867a7 to
31b8652
Compare
ianpartridge
force-pushed
the
urlrequest-description
branch
from
31b8652 to
65c2809
Compare
Contributor
Author
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
NSURLRequest.descriptionto match Darwin. Add tests.Also add a test for
URLRequest.descriptionwhich was already correct but untested.