NSURLRequest: implement description and add tests

Author: ianpartridge

Foundation/NSURLRequest.swift

@@ -324,6 +324,11 @@ open class NSURLRequest : NSObject, NSSecureCoding, NSCopying, NSMutableCopying
     open internal(set) var httpShouldHandleCookies: Bool = true
 
     open internal(set) var httpShouldUsePipelining: Bool = true
+
+    open override var description: String {
+        let url = self.url?.description ?? "(null)"
+        return super.description + " { URL: \(url) }"
+    }
 }
 
 /// An `NSMutableURLRequest` object represents a mutable URL load

TestFoundation/TestNSURLRequest.swift

@@ -29,7 +29,8 @@ class TestNSURLRequest : XCTestCase {
             ("test_mutableCopy_3", test_mutableCopy_3),
             ("test_NSCoding_1", test_NSCoding_1),
             ("test_NSCoding_2", test_NSCoding_2),
-            ("test_NSCoding_3", test_NSCoding_3)
+            ("test_NSCoding_3", test_NSCoding_3),
+            ("test_description", test_description),
         ]
     }
 
@@ -240,4 +241,18 @@ class TestNSURLRequest : XCTestCase {
         XCTAssertEqual(3, requestB.httpBody!.count)
         XCTAssertEqual(requestB.httpBody, requestA.httpBody)
     }
+
+    func test_description() {
+        let url = URL(string: "http://swift.org")!
+        let request = NSMutableURLRequest(url: url)
+
+        if request.description.range(of: "http://swift.org") == nil {
+            XCTFail("description should contain URL")
+        }
+
+        request.url = nil
+        if request.description.range(of: "(null)") == nil {
+            XCTFail("description of nil URL should contain (null)")
+        }
+    }
 }

TestFoundation/TestURLRequest.swift

@@ -27,6 +27,7 @@ class TestURLRequest : XCTestCase {
             ("test_mutableCopy_1", test_mutableCopy_1),
             ("test_mutableCopy_2", test_mutableCopy_2),
             ("test_mutableCopy_3", test_mutableCopy_3),
+            ("test_description", test_description),
         ]
     }
 
@@ -194,5 +195,15 @@ class TestURLRequest : XCTestCase {
         XCTAssertEqual(originalRequest.url, urlA)
         XCTAssertNil(originalRequest.allHTTPHeaderFields)
     }
+
+    func test_description() {
+        let url = URL(string: "http://swift.org")!
+
+        var request = URLRequest(url: url)
+        XCTAssertEqual(request.description, "http://swift.org")
+
+        request.url = nil
+        XCTAssertEqual(request.description, "url: nil")
+    }
 }