Skip to content

Add more test discovery tests #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Add more test discovery tests #1560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
202 changes: 158 additions & 44 deletions Tests/SourceKitLSPTests/DocumentTestDiscoveryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ final class DocumentTestDiscoveryTests: XCTestCase {
)
}

func testNestedSwiftTestingSuites() async throws {
func testSwiftTestingNestedSuites() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

Expand Down Expand Up @@ -295,7 +295,7 @@ final class DocumentTestDiscoveryTests: XCTestCase {
)
}

func testParameterizedSwiftTestingTest() async throws {
func testSwiftTestingParameterizedTest() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

Expand Down Expand Up @@ -335,7 +335,7 @@ final class DocumentTestDiscoveryTests: XCTestCase {
)
}

func testParameterizedSwiftTestingTestWithAnonymousArgument() async throws {
func testSwiftTestingParameterizedTestWithAnonymousArgument() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

Expand Down Expand Up @@ -378,7 +378,7 @@ final class DocumentTestDiscoveryTests: XCTestCase {
)
}

func testParameterizedSwiftTestingTestWithCommentInSignature() async throws {
func testSwiftTestingParameterizedTestWithCommentInSignature() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

Expand Down Expand Up @@ -559,7 +559,7 @@ final class DocumentTestDiscoveryTests: XCTestCase {
)
}

func testDisabledSwiftTestingTest() async throws {
func testSwiftTestingTestDisabledTest() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

Expand Down Expand Up @@ -633,7 +633,7 @@ final class DocumentTestDiscoveryTests: XCTestCase {
)
}

func testHiddenSwiftTestingTest() async throws {
func testSwiftTestingHiddenTest() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

Expand Down Expand Up @@ -859,43 +859,6 @@ final class DocumentTestDiscoveryTests: XCTestCase {
)
}

func testXCTestTestsWithExtension() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

let positions = testClient.openDocument(
"""
import XCTest

1️⃣final class MyTests: XCTestCase {}2️⃣

extension MyTests {
3️⃣func testOneIsTwo() {}4️⃣
}
""",
uri: uri
)

let tests = try await testClient.send(DocumentTestsRequest(textDocument: TextDocumentIdentifier(uri)))
XCTAssertEqual(
tests,
[
TestItem(
id: "MyTests",
label: "MyTests",
location: Location(uri: uri, range: positions["1️⃣"]..<positions["2️⃣"]),
children: [
TestItem(
id: "MyTests/testOneIsTwo()",
label: "testOneIsTwo()",
location: Location(uri: uri, range: positions["3️⃣"]..<positions["4️⃣"])
)
]
)
]
)
}

func testSwiftTestingNestedTestSuiteWithExtension() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)
Expand Down Expand Up @@ -1086,7 +1049,87 @@ final class DocumentTestDiscoveryTests: XCTestCase {
)
}

func testFullyQualifySwiftTestingTestAttribute() async throws {
func testSwiftTestingEnumSuite() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

let positions = testClient.openDocument(
"""
import Testing

1️⃣enum MyTests {
2️⃣@Test
static func oneIsTwo() {
#expect(1 == 2)
}3️⃣
}4️⃣
""",
uri: uri
)

let tests = try await testClient.send(DocumentTestsRequest(textDocument: TextDocumentIdentifier(uri)))
XCTAssertEqual(
tests,
[
TestItem(
id: "MyTests",
label: "MyTests",
style: TestStyle.swiftTesting,
location: Location(uri: uri, range: positions["1️⃣"]..<positions["4️⃣"]),
children: [
TestItem(
id: "MyTests/oneIsTwo()",
label: "oneIsTwo()",
style: TestStyle.swiftTesting,
location: Location(uri: uri, range: positions["2️⃣"]..<positions["3️⃣"])
)
]
)
]
)
}

func testSwiftTestingActorSuite() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

let positions = testClient.openDocument(
"""
import Testing

1️⃣actor MyTests {
2️⃣@Test
static func oneIsTwo() {
#expect(1 == 2)
}3️⃣
}4️⃣
""",
uri: uri
)

let tests = try await testClient.send(DocumentTestsRequest(textDocument: TextDocumentIdentifier(uri)))
XCTAssertEqual(
tests,
[
TestItem(
id: "MyTests",
label: "MyTests",
style: TestStyle.swiftTesting,
location: Location(uri: uri, range: positions["1️⃣"]..<positions["4️⃣"]),
children: [
TestItem(
id: "MyTests/oneIsTwo()",
label: "oneIsTwo()",
style: TestStyle.swiftTesting,
location: Location(uri: uri, range: positions["2️⃣"]..<positions["3️⃣"])
)
]
)
]
)
}

func testSwiftTestingFullyQualifyTestAttribute() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

Expand Down Expand Up @@ -1127,6 +1170,77 @@ final class DocumentTestDiscoveryTests: XCTestCase {
)
}

func testXCTestTestsWithExtension() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

let positions = testClient.openDocument(
"""
import XCTest

1️⃣final class MyTests: XCTestCase {}2️⃣

extension MyTests {
3️⃣func testOneIsTwo() {}4️⃣
}
""",
uri: uri
)

let tests = try await testClient.send(DocumentTestsRequest(textDocument: TextDocumentIdentifier(uri)))
XCTAssertEqual(
tests,
[
TestItem(
id: "MyTests",
label: "MyTests",
location: Location(uri: uri, range: positions["1️⃣"]..<positions["2️⃣"]),
children: [
TestItem(
id: "MyTests/testOneIsTwo()",
label: "testOneIsTwo()",
location: Location(uri: uri, range: positions["3️⃣"]..<positions["4️⃣"])
)
]
)
]
)
}

func testXCTestInvalidXCTestSuiteConstructions() async throws {
let testClient = try await TestSourceKitLSPClient()
let uri = DocumentURI(for: .swift)

let positions = testClient.openDocument(
"""
import XCTest

// This comment contains the string XCTestCase
final class NSObjectInheritance: NSObject {}
final class BaseClass {}
final class MyEmptyTests: BaseClass {}
1️⃣final class MyTests: XCTestCase {
static func testStaticFuncIsNotATest() {}
}2️⃣
""",
uri: uri
)

let tests = try await testClient.send(DocumentTestsRequest(textDocument: TextDocumentIdentifier(uri)))

XCTAssertEqual(
tests,
[
TestItem(
id: "MyTests",
label: "MyTests",
location: Location(uri: uri, range: positions["1️⃣"]..<positions["2️⃣"]),
children: []
)
]
)
}

func testAddNewMethodToNotQuiteTestCase() async throws {
let project = try await IndexedSingleSwiftFileTestProject(
"""
Expand Down