Skip to content

Conversation

@plemarquand
Copy link
Contributor

@plemarquand plemarquand commented Jul 9, 2024

Add some more tests around test discovery. Test swift testing tests found in enums, as well as the cases that exit early when looking for XCTests. Also renames some tests to consistently reflect whether they are testing XCTest or swift-testing tests.

Add some more tests around test discovery. Test swift testing tests
found in enums, as well as the cases that exit early when looking for
XCTests.
@plemarquand plemarquand requested a review from ahoppen as a code owner July 9, 2024 16:22
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Out of curiosity: Did you see any issues that made you write these test cases or did you just think it would be good to have them?

@ahoppen
Copy link
Member

ahoppen commented Jul 15, 2024

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge July 15, 2024 09:13
@ahoppen ahoppen merged commit ab9513e into swiftlang:main Jul 15, 2024
@plemarquand
Copy link
Contributor Author

No specific issues, this just came out of trying to improve the code coverage workflow in VS Code and sourcekit-lsp is a great place to try it out.

@ahoppen
Copy link
Member

ahoppen commented Jul 16, 2024

Ah, I see. 😄

@plemarquand plemarquand deleted the add-more-doc-discovery-tests branch July 16, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants