[lldb] Add list of types known to use @_originallyDefinedIn #6886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci test |
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeDynamicTypeResolution.cpp
Outdated
Show resolved
Hide resolved
Types defined wit @_originallyDefinedIn have a different mangled name emitted in the debug information and in the reflection metadata. Add a map of known common types that use this feature so we can find reflection metadata for them. rdar://106506535
augusto2112
force-pushed
the
originally-def-cgfloat
branch
from
06985de to
010321d
Compare
Author
|
@swift-ci test |
Author
|
@swift-ci test Windows |
Author
|
@swift-ci test windows |
| if (mangled_name == "$sSo7CGPointVD") | ||
| return true; | ||
|
|
||
| if (mangled_name == "$sSo6CGSizeVD") |
There was a problem hiding this comment.
Does CGSize have the same problem?
adrian-prantl
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types defined wit @_originallyDefinedIn have a different mangled name
emitted in the debug information and in the reflection metadata. Add a
map of known common types that use this feature so we can find
reflection metadata for them.
rdar://106506535