[lldb] Add fallback to TypeSystemSwiftTypeRef::GetByteStride #6314
Conversation
If TypeSystemSwiftTypeRef::GetByteStride fails, we should fallback to SwiftASTContext, much like the other functions in the typeref typesystem. rdar://105124851
|
@swift-ci test |
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
Hmm.. I guess the runtime data could be corrupt or missing and then this would be of advatage. Is there a specific test case that motivates this?
|
@adrian-prantl for some reason we can't find type information for CFGloats using the runtime. I think we should investigate that separately as well, but we should fallback to swift ast context here, to mirror how other functions in TypeSystemSwiftTyperef behave when the runtime fails for whatever reason. |
|
CGFloat is both a special-cased type in ClangImporter, and it may also have been moved between frameworks in the past... |
|
Might be worth adding a test for that type regardless |
|
@swift-ci test |
|
@swift-ci test windows |
|
@adrian-prantl could you merge this? The underlying CGFloat issue is solved by #6886 but we should add this fallback to GetByteStride anyway |
2 participants
If TypeSystemSwiftTypeRef::GetByteStride fails, we should fallback to SwiftASTContext, much like the other functions in the typeref typesystem.
rdar://105124851