Skip to content

🍒/navy/9aa6a479738c7bf21128f9c45ea4ffcf82d80cbf+02c2b472b510ff55679844c087b66e7837e13dc2 #6522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023
Merged

🍒/navy/9aa6a479738c7bf21128f9c45ea4ffcf82d80cbf+02c2b472b510ff55679844c087b66e7837e13dc2 #6522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee11eac
[lldb] Fix crash when launching in terminal
JDevlieghere Apr 28, 2022
d27d854
[lldb] Remove ConnectionFileDescriptorTest.Connectv(4|6)
JDevlieghere Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ bool ConnectionFileDescriptor::IsConnected() const {

ConnectionStatus ConnectionFileDescriptor::Connect(llvm::StringRef path,
Status *error_ptr) {
return Connect(path, nullptr, error_ptr);
return Connect(
path, [](llvm::StringRef) {}, error_ptr);
}

ConnectionStatus
Expand Down
2 changes: 1 addition & 1 deletion lldb/unittests/Host/ConnectionFileDescriptorTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class ConnectionFileDescriptorTest : public testing::Test {
std::unique_ptr<TCPSocket> socket_a_up;
std::unique_ptr<TCPSocket> socket_b_up;
CreateTCPConnectedSockets(ip, &socket_a_up, &socket_b_up);
auto socket = socket_a_up.release();
auto *socket = socket_a_up.release();
ConnectionFileDescriptor connection_file_descriptor(socket);

std::string uri(connection_file_descriptor.GetURI());
Expand Down