🍒/navy/9aa6a479738c7bf21128f9c45ea4ffcf82d80cbf+02c2b472b510ff55679844c087b66e7837e13dc2 #6522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDevlieghere
commented
Mar 22, 2023
JDevlieghere
commented
- [lldb] Fix crash when launching in terminal
- [lldb] Remove ConnectionFileDescriptorTest.Connectv(4|6)
This patch fixes a crash when using process launch -t to launch the inferior from a TTY. The issue is that on Darwin, Host.mm is calling ConnectionFileDescriptor::Connect without a socket_id_callback_type. The overload passes nullptr as the function ref, which gets called unconditionally as the socket_id_callback. One potential way to fix this is to change all the lambdas to include a null check, but instead I went with an empty lambda. Differential revision: https://reviews.llvm.org/D124535 (cherry picked from commit 9aa6a47)
These tests are timing out on the bots. (cherry picked from commit 02c2b47)
Author
|
@swift-ci please test |
1 similar comment
Author
|
@swift-ci please test |
JDevlieghere
deleted the
🍒/navy/9aa6a479738c7bf21128f9c45ea4ffcf82d80cbf+02c2b472b510ff55679844c087b66e7837e13dc2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.