Skip to content

Cherry pick missing NodeType enums from swift/main #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2020
Merged

Cherry pick missing NodeType enums from swift/main #1882

merged 1 commit into from
Sep 30, 2020

Conversation

@texasmichelle
Copy link

@texasmichelle texasmichelle commented Sep 30, 2020

From #1863:

Add enum values from AArch64ISelLowering.h that resolve the error:

third_party/unsupported_toolchains/swift/src/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1379:11: error: enumeration values 'AUTH_CALL' and 'AUTH_TC_RETURN' not handled in switch [-Werror,-Wswitch]
  switch ((AArch64ISD::NodeType)Opcode) {
          ^

@texasmichelle
Copy link
Author

texasmichelle commented Sep 30, 2020

@swift-ci please test

dabrahams
dabrahams approved these changes Sep 30, 2020
View reviewed changes
Copy link

@dabrahams dabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd
Copy link
Member

compnerd commented Sep 30, 2020

@swift-ci please test tensorflow

@texasmichelle texasmichelle force-pushed the cherry-pick-nodetype-tf branch from a542f75 to c99ca9f Compare September 30, 2020 23:17
@texasmichelle texasmichelle changed the title Cherry pick missing NodeType enums from apple/main Cherry pick missing NodeType enums from swift/main Sep 30, 2020
dabrahams
dabrahams approved these changes Sep 30, 2020
View reviewed changes
Copy link

@dabrahams dabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@texasmichelle texasmichelle merged commit f20be2d into swiftlang:swift/tensorflow Sep 30, 2020
@texasmichelle texasmichelle deleted the cherry-pick-nodetype-tf branch September 30, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dabrahams dabrahams dabrahams approved these changes

@compnerd compnerd Awaiting requested review from compnerd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@texasmichelle @compnerd @dabrahams