Skip to content

Add missing NodeType enums #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2020
Merged

Add missing NodeType enums #1863

merged 2 commits into from
Sep 28, 2020

Conversation

@texasmichelle
Copy link

@texasmichelle texasmichelle commented Sep 25, 2020

Add enum values from AArch64ISelLowering.h that resolve the error:

third_party/unsupported_toolchains/swift/src/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1379:11: error: enumeration values 'AUTH_CALL' and 'AUTH_TC_RETURN' not handled in switch [-Werror,-Wswitch]
  switch ((AArch64ISD::NodeType)Opcode) {
          ^

@compnerd
Copy link
Member

compnerd commented Sep 25, 2020

@swift-ci please test

@compnerd
Copy link
Member

compnerd commented Sep 25, 2020

CC: @ahmedbougacha @hyp

@texasmichelle
Copy link
Author

texasmichelle commented Sep 26, 2020

@swift-ci please clean test

@compnerd
Copy link
Member

compnerd commented Sep 28, 2020

@swift-ci please test

hyp
hyp approved these changes Sep 28, 2020
View reviewed changes
Copy link

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@texasmichelle texasmichelle merged commit 26ec8e3 into swiftlang:apple/main Sep 28, 2020
@texasmichelle texasmichelle deleted the missing_nodetype_main branch September 28, 2020 22:03
This was referenced Sep 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyp hyp hyp approved these changes

@compnerd compnerd Awaiting requested review from compnerd

@ahmedbougacha ahmedbougacha Awaiting requested review from ahmedbougacha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@texasmichelle @compnerd @hyp