-
Notifications
You must be signed in to change notification settings - Fork 33
[test] Migrate unit tests to Swift Testing #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4d77dea
migrate unit test
sebsto 7138f1b
swift format
sebsto a918a1c
fix errors on Swift 6.2
sebsto 33698ed
swift-format
sebsto 22ef182
fix warnings
sebsto 6e9265f
run the test on Swift >= 6.0 only
sebsto 5e04c97
swift-format
sebsto 5653a49
remove platform requirement
sebsto dfd0a26
revert to min version 5.8
sebsto ec537f7
bump version to 5.10
sebsto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,3 +10,4 @@ xcuserdata | |
Package.resolved | ||
.serverless | ||
.devcontainer | ||
.amazonq |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// swift-tools-version:5.8 | ||
// swift-tools-version:6.0 | ||
|
||
import PackageDescription | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// swift-tools-version:5.10 | ||
|
||
import PackageDescription | ||
|
||
let swiftSettings: [SwiftSetting] = [.enableExperimentalFeature("StrictConcurrency=complete")] | ||
|
||
let package = Package( | ||
name: "swift-aws-lambda-events", | ||
platforms: [.macOS(.v14)], | ||
products: [ | ||
.library(name: "AWSLambdaEvents", targets: ["AWSLambdaEvents"]) | ||
], | ||
dependencies: [ | ||
.package(url: "https://github.com/apple/swift-docc-plugin", from: "1.0.0"), | ||
.package(url: "https://github.com/apple/swift-http-types.git", from: "1.0.0"), | ||
], | ||
targets: [ | ||
.target( | ||
name: "AWSLambdaEvents", | ||
dependencies: [ | ||
.product(name: "HTTPTypes", package: "swift-http-types") | ||
], | ||
swiftSettings: swiftSettings | ||
) | ||
] | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// swift-tools-version:5.8 | ||
|
||
import PackageDescription | ||
|
||
let swiftSettings: [SwiftSetting] = [.enableExperimentalFeature("StrictConcurrency=complete")] | ||
|
||
let package = Package( | ||
name: "swift-aws-lambda-events", | ||
platforms: [.macOS(.v14)], | ||
products: [ | ||
.library(name: "AWSLambdaEvents", targets: ["AWSLambdaEvents"]) | ||
], | ||
dependencies: [ | ||
.package(url: "https://github.com/apple/swift-docc-plugin", from: "1.0.0"), | ||
.package(url: "https://github.com/apple/swift-http-types.git", from: "1.0.0"), | ||
], | ||
targets: [ | ||
.target( | ||
name: "AWSLambdaEvents", | ||
dependencies: [ | ||
.product(name: "HTTPTypes", package: "swift-http-types") | ||
], | ||
swiftSettings: swiftSettings | ||
) | ||
] | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is standard to just support the last three versions of swift. So you should only need to support 5.10.
Does [email protected] work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Will update to 5.10 before merging.
Yes it works, it is picked up for any 5.x version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.