[test] Migrate unit tests to Swift Testing #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsto
added
🔨 semver/patch
sebsto
added
⚠️ semver/major
adam-fowler
reviewed
Jun 29, 2025
Package.swift
Outdated
|
|
||
| import PackageDescription | ||
|
|
||
| let swiftSettings: [SwiftSetting] = [.enableExperimentalFeature("StrictConcurrency=complete")] | ||
|
|
||
| let package = Package( | ||
| name: "swift-aws-lambda-events", | ||
| platforms: [.macOS(.v15)], |
There was a problem hiding this comment.
Why do you need to add the platform requirement?
There was a problem hiding this comment.
If it is needed for swift-testing you could add a @available at the top of each suite.
Also you could just wrap all the tests in a #if compiler(>=6.0) to avoid requiring swift 6
There was a problem hiding this comment.
I propose an alternative : I created a [email protected] with no test target and keep the tests running for Swift 6.x only.
The CI runs tests on 6.x anyway.
Would that work ?
sebsto
added
🆕 semver/minor
|
adjusted tag to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate all unti tests to Swift Testing
Motivation:
Allows to compile and run test on open source Swift toolchain 6
Modifications:
Migrate according to
https://developer.apple.com/documentation/testing/migratingfromxctest
Result: