chore: rename serialize_ prefix to build_ #12696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm taking advantage of the fact that Dominic and Simon are on holiday to fix various minor things that have been bugging me for a while, without needing to worry about merge conflicts and whatnot.
We use the word 'serialize' in a really weird way — it means 'convert into a byte stream', but all the
serialize_foofunctions return ESTree nodes. It's also a long, awkward word to type, and it's four syllables (try sayingserialize_custom_element_attribute_update_assignmentten times fast).There's already a perfectly good (one-syllable!) word that describes the process of creating ESTree nodes, and we use it throughout the codebase courtesy of this module.
It's Time To Build.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint