Skip to content

Conversation

@Rich-Harris
Copy link
Member

I'm taking advantage of the fact that Dominic and Simon are on holiday to fix various minor things that have been bugging me for a while, without needing to worry about merge conflicts and whatnot.

We use the word 'serialize' in a really weird way — it means 'convert into a byte stream', but all the serialize_foo functions return ESTree nodes. It's also a long, awkward word to type, and it's four syllables (try saying serialize_custom_element_attribute_update_assignment ten times fast).

There's already a perfectly good (one-syllable!) word that describes the process of creating ESTree nodes, and we use it throughout the codebase courtesy of this module.

It's Time To Build.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: 6506f2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 4fd7834 into main Aug 2, 2024
@Rich-Harris Rich-Harris deleted the rename-serialize branch August 2, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants