chore: rename serialize_ prefix to build_ (#12696)

Author: Rich-Harris

packages/svelte/src/compiler/phases/3-transform/client/transform-client.js

@@ -5,7 +5,7 @@
 import { walk } from 'zimmerframe';
 import * as b from '../../../utils/builders.js';
 import { set_scope } from '../../scope.js';
-import { serialize_get_binding } from './utils.js';
+import { build_getter } from './utils.js';
 import { render_stylesheet } from '../css/index.js';
 import { dev, filename } from '../../../state.js';
 import { AnimateDirective } from './visitors/AnimateDirective.js';
@@ -198,7 +198,7 @@ export function client_component(analysis, options) {
 			}
 
 			// We're creating an arrow function that gets the store value which minifies better for two or more references
-			const store_reference = serialize_get_binding(b.id(name.slice(1)), instance_state);
+			const store_reference = build_getter(b.id(name.slice(1)), instance_state);
 			const store_get = b.call('$.store_get', store_reference, b.literal(name), b.id('$$stores'));
 			store_setup.push(
 				b.const(
@@ -240,7 +240,7 @@ export function client_component(analysis, options) {
 	/** @type {Array<ESTree.Property | ESTree.SpreadElement>} */
 	const component_returned_object = analysis.exports.flatMap(({ name, alias }) => {
 		const binding = instance_state.scope.get(name);
-		const expression = serialize_get_binding(b.id(name), instance_state);
+		const expression = build_getter(b.id(name), instance_state);
 		const getter = b.get(alias ?? name, [b.return(expression)]);
 
 		if (expression.type === 'Identifier') {
@@ -365,7 +365,7 @@ export function client_component(analysis, options) {
 						'$.bind_prop',
 						b.id('$$props'),
 						b.literal(alias ?? name),
-						serialize_get_binding(b.id(name), instance_state)
+						build_getter(b.id(name), instance_state)
 					)
 				)
 			);

packages/svelte/src/compiler/phases/3-transform/client/utils.js

@@ -32,7 +32,7 @@ export function get_assignment_value(node, { state, visit }) {
 			: // turn something like x += 1 into x = x + 1
 				b.binary(
 					/** @type {BinaryOperator} */ (operator.slice(0, -1)),
-					serialize_get_binding(node.left, state),
+					build_getter(node.left, state),
 					/** @type {Expression} */ (visit(node.right))
 				);
 	} else if (
@@ -72,7 +72,7 @@ export function is_state_source(binding, state) {
  * @param {ClientTransformState} state
  * @returns {Expression}
  */
-export function serialize_get_binding(node, state) {
+export function build_getter(node, state) {
 	const binding = state.scope.get(node.name);
 
 	if (binding === null || node === binding.node) {
@@ -130,7 +130,7 @@ export function serialize_get_binding(node, state) {
  * @param {{skip_proxy_and_freeze?: boolean}} [options]
  * @returns {Expression}
  */
-export function serialize_set_binding(node, context, fallback, prefix, options) {
+export function build_setter(node, context, fallback, prefix, options) {
 	const { state, visit } = context;
 
 	const assignee = node.left;
@@ -154,9 +154,7 @@ export function serialize_set_binding(node, context, fallback, prefix, options)
 			const value = path.expression?.(b.id(tmp_id));
 			const assignment = b.assignment('=', path.node, value);
 			original_assignments.push(assignment);
-			assignments.push(
-				serialize_set_binding(assignment, context, () => assignment, prefix, options)
-			);
+			assignments.push(build_setter(assignment, context, () => assignment, prefix, options));
 		}
 
 		if (assignments.every((assignment, i) => assignment === original_assignments[i])) {
@@ -213,7 +211,7 @@ export function serialize_set_binding(node, context, fallback, prefix, options)
 							assignment.right =
 								private_state.kind === 'frozen_state'
 									? b.call('$.freeze', value)
-									: serialize_proxy_reassignment(value, private_state.id);
+									: build_proxy_reassignment(value, private_state.id);
 							return assignment;
 						}
 					}
@@ -226,7 +224,7 @@ export function serialize_set_binding(node, context, fallback, prefix, options)
 							should_proxy_or_freeze(value, context.state.scope)
 							? private_state.kind === 'frozen_state'
 								? b.call('$.freeze', value)
-								: serialize_proxy_reassignment(value, private_state.id)
+								: build_proxy_reassignment(value, private_state.id)
 							: value
 					);
 				}
@@ -250,7 +248,7 @@ export function serialize_set_binding(node, context, fallback, prefix, options)
 					assignment.right =
 						public_state.kind === 'frozen_state'
 							? b.call('$.freeze', value)
-							: serialize_proxy_reassignment(value, public_state.id);
+							: build_proxy_reassignment(value, public_state.id);
 					return assignment;
 				}
 			}
@@ -324,7 +322,7 @@ export function serialize_set_binding(node, context, fallback, prefix, options)
 			if ((binding.kind === 'prop' || binding.kind === 'bindable_prop') && !is_initial_proxy) {
 				return b.call(left, value);
 			} else if (is_store) {
-				return b.call('$.store_set', serialize_get_binding(b.id(left_name), state), value);
+				return b.call('$.store_set', build_getter(b.id(left_name), state), value);
 			} else {
 				let call;
 				if (binding.kind === 'state') {
@@ -334,7 +332,7 @@ export function serialize_set_binding(node, context, fallback, prefix, options)
 						context.state.analysis.runes &&
 							!options?.skip_proxy_and_freeze &&
 							should_proxy_or_freeze(value, context.state.scope)
-							? serialize_proxy_reassignment(value, left_name)
+							? build_proxy_reassignment(value, left_name)
 							: value
 					);
 				} else if (binding.kind === 'frozen_state') {
@@ -357,7 +355,7 @@ export function serialize_set_binding(node, context, fallback, prefix, options)
 							!options?.skip_proxy_and_freeze &&
 							should_proxy_or_freeze(value, context.state.scope) &&
 							binding.kind === 'bindable_prop'
-							? serialize_proxy_reassignment(value, left_name)
+							? build_proxy_reassignment(value, left_name)
 							: value
 					);
 				} else {
@@ -401,7 +399,7 @@ export function serialize_set_binding(node, context, fallback, prefix, options)
 				return maybe_skip_ownership_validation(
 					b.call(
 						'$.store_mutate',
-						serialize_get_binding(b.id(left_name), state),
+						build_getter(b.id(left_name), state),
 						b.assignment(node.operator, /** @type {Pattern}} */ (visit_node(node.left)), value),
 						b.call('$.untrack', b.id('$' + left_name))
 					)
@@ -453,7 +451,7 @@ export function serialize_set_binding(node, context, fallback, prefix, options)
 	};
 
 	if (value.type === 'BinaryExpression' && /** @type {any} */ (value.operator) === '??') {
-		return b.logical('??', serialize_get_binding(b.id(left_name), state), serialize());
+		return b.logical('??', build_getter(b.id(left_name), state), serialize());
 	}
 
 	return serialize();
@@ -463,7 +461,7 @@ export function serialize_set_binding(node, context, fallback, prefix, options)
  * @param {Expression} value
  * @param {PrivateIdentifier | string} proxy_reference
  */
-export function serialize_proxy_reassignment(value, proxy_reference) {
+export function build_proxy_reassignment(value, proxy_reference) {
 	return dev
 		? b.call(
 				'$.proxy',
@@ -549,7 +547,7 @@ function get_hoistable_params(node, context) {
  * @param {ComponentContext} context
  * @returns {Pattern[]}
  */
-export function serialize_hoistable_params(node, context) {
+export function build_hoistable_params(node, context) {
 	const hoistable_params = get_hoistable_params(node, context);
 	node.metadata.hoistable_params = hoistable_params;
 

packages/svelte/src/compiler/phases/3-transform/client/visitors/AssignmentExpression.js

@@ -1,11 +1,11 @@
 /** @import { AssignmentExpression } from 'estree' */
 /** @import { Context } from '../types' */
-import { serialize_set_binding } from '../utils.js';
+import { build_setter } from '../utils.js';
 
 /**
  * @param {AssignmentExpression} node
  * @param {Context} context
  */
 export function AssignmentExpression(node, context) {
-	return serialize_set_binding(node, context, context.next);
+	return build_setter(node, context, context.next);
 }

packages/svelte/src/compiler/phases/3-transform/client/visitors/Attribute.js

@@ -1,14 +1,14 @@
 /** @import { Attribute } from '#compiler' */
 /** @import { ComponentContext } from '../types' */
 import { is_event_attribute } from '../../../../utils/ast.js';
-import { serialize_event_attribute } from './shared/element.js';
+import { build_event_attribute } from './shared/element.js';
 
 /**
  * @param {Attribute} node
  * @param {ComponentContext} context
  */
 export function Attribute(node, context) {
 	if (is_event_attribute(node)) {
-		serialize_event_attribute(node, context);
+		build_event_attribute(node, context);
 	}
 }

packages/svelte/src/compiler/phases/3-transform/client/visitors/BindDirective.js

@@ -5,9 +5,9 @@ import { dev, is_ignored } from '../../../../state.js';
 import { is_text_attribute } from '../../../../utils/ast.js';
 import * as b from '../../../../utils/builders.js';
 import { binding_properties } from '../../../bindings.js';
-import { serialize_set_binding } from '../utils.js';
-import { serialize_attribute_value } from './shared/element.js';
-import { serialize_bind_this, serialize_validate_binding } from './shared/utils.js';
+import { build_setter } from '../utils.js';
+import { build_attribute_value } from './shared/element.js';
+import { build_bind_this, build_validate_binding } from './shared/utils.js';
 
 /**
  * @param {BindDirective} node
@@ -31,7 +31,7 @@ export function BindDirective(node, context) {
 		!is_ignored(node, 'binding_property_non_reactive')
 	) {
 		context.state.init.push(
-			serialize_validate_binding(
+			build_validate_binding(
 				context.state,
 				node,
 				/**@type {MemberExpression} */ (context.visit(expression))
@@ -43,7 +43,7 @@ export function BindDirective(node, context) {
 	const assignment = b.assignment('=', expression, b.id('$$value'));
 	const setter = b.arrow(
 		[b.id('$$value')],
-		serialize_set_binding(
+		build_setter(
 			assignment,
 			context,
 			() => /** @type {Expression} */ (context.visit(assignment)),
@@ -161,7 +161,7 @@ export function BindDirective(node, context) {
 				break;
 
 			case 'this':
-				call = serialize_bind_this(expression, context.state.node, context);
+				call = build_bind_this(expression, context.state.node, context);
 				break;
 
 			case 'textContent':
@@ -212,7 +212,7 @@ export function BindDirective(node, context) {
 					if (value !== undefined) {
 						group_getter = b.thunk(
 							b.block([
-								b.stmt(serialize_attribute_value(value, context)[1]),
+								b.stmt(build_attribute_value(value, context)[1]),
 								b.return(/** @type {Expression} */ (context.visit(expression)))
 							])
 						);

packages/svelte/src/compiler/phases/3-transform/client/visitors/ClassBody.js

@@ -5,7 +5,7 @@ import { dev, is_ignored } from '../../../../state.js';
 import * as b from '../../../../utils/builders.js';
 import { regex_invalid_identifier_chars } from '../../../patterns.js';
 import { get_rune } from '../../../scope.js';
-import { serialize_proxy_reassignment, should_proxy_or_freeze } from '../utils.js';
+import { build_proxy_reassignment, should_proxy_or_freeze } from '../utils.js';
 
 /**
  * @param {ClassBody} node
@@ -149,7 +149,7 @@ export function ClassBody(node, context) {
 								'set',
 								definition.key,
 								[value],
-								[b.stmt(b.call('$.set', member, serialize_proxy_reassignment(value, field.id)))]
+								[b.stmt(b.call('$.set', member, build_proxy_reassignment(value, field.id)))]
 							)
 						);
 					}

packages/svelte/src/compiler/phases/3-transform/client/visitors/Component.js

@@ -2,7 +2,7 @@
 /** @import { Component } from '#compiler' */
 /** @import { ComponentContext } from '../types' */
 import * as b from '../../../../utils/builders.js';
-import { serialize_component } from './shared/component.js';
+import { build_component } from './shared/component.js';
 
 /**
  * @param {Component} node
@@ -11,7 +11,7 @@ import { serialize_component } from './shared/component.js';
 export function Component(node, context) {
 	if (node.metadata.dynamic) {
 		// Handle dynamic references to what seems like static inline components
-		const component = serialize_component(node, '$$component', context, b.id('$$anchor'));
+		const component = build_component(node, '$$component', context, b.id('$$anchor'));
 		context.state.init.push(
 			b.stmt(
 				b.call(
@@ -27,6 +27,6 @@ export function Component(node, context) {
 		return;
 	}
 
-	const component = serialize_component(node, node.name, context);
+	const component = build_component(node, node.name, context);
 	context.state.init.push(component);
 }

packages/svelte/src/compiler/phases/3-transform/client/visitors/EachBlock.js

@@ -12,12 +12,7 @@ import {
 import { dev } from '../../../../state.js';
 import { extract_paths, object } from '../../../../utils/ast.js';
 import * as b from '../../../../utils/builders.js';
-import {
-	get_assignment_value,
-	serialize_get_binding,
-	serialize_set_binding,
-	with_loc
-} from '../utils.js';
+import { get_assignment_value, build_getter, build_setter, with_loc } from '../utils.js';
 
 /**
  * @param {EachBlock} node
@@ -94,7 +89,7 @@ export function EachBlock(node, context) {
 	// Legacy mode: find the parent each blocks which contain the arrays to invalidate
 	const indirect_dependencies = collect_parent_each_blocks(context).flatMap((block) => {
 		const array = /** @type {Expression} */ (context.visit(block.expression));
-		const transitive_dependencies = serialize_transitive_dependencies(
+		const transitive_dependencies = build_transitive_dependencies(
 			block.metadata.references,
 			context
 		);
@@ -106,7 +101,7 @@ export function EachBlock(node, context) {
 	} else {
 		indirect_dependencies.push(collection);
 
-		const transitive_dependencies = serialize_transitive_dependencies(
+		const transitive_dependencies = build_transitive_dependencies(
 			each_node_meta.references,
 			context
 		);
@@ -131,9 +126,9 @@ export function EachBlock(node, context) {
 	const create_mutation = (expression_for_id) => {
 		return (assignment, context) => {
 			if (assignment.left.type !== 'Identifier' && assignment.left.type !== 'MemberExpression') {
-				// serialize_set_binding turns other patterns into IIFEs and separates the assignments
+				// build_setter turns other patterns into IIFEs and separates the assignments
 				// into separate expressions, at which point this is called again with an identifier or member expression
-				return serialize_set_binding(assignment, context, () => assignment);
+				return build_setter(assignment, context, () => assignment);
 			}
 
 			const left = object(assignment.left);
@@ -282,7 +277,7 @@ function collect_parent_each_blocks(context) {
  * @param {Binding[]} references
  * @param {ComponentContext} context
  */
-function serialize_transitive_dependencies(references, context) {
+function build_transitive_dependencies(references, context) {
 	/** @type {Set<Binding>} */
 	const dependencies = new Set();
 
@@ -293,7 +288,7 @@ function serialize_transitive_dependencies(references, context) {
 		}
 	}
 
-	return [...dependencies].map((dep) => serialize_get_binding({ ...dep.node }, context.state));
+	return [...dependencies].map((dep) => build_getter({ ...dep.node }, context.state));
 }
 
 /**

packages/svelte/src/compiler/phases/3-transform/client/visitors/Fragment.js

@@ -7,7 +7,7 @@ import { dev } from '../../../../state.js';
 import * as b from '../../../../utils/builders.js';
 import { clean_nodes, infer_namespace } from '../../utils.js';
 import { process_children } from './shared/fragment.js';
-import { serialize_render_stmt } from './shared/utils.js';
+import { build_render_statement } from './shared/utils.js';
 
 /**
  * @param {Fragment} node
@@ -97,7 +97,7 @@ export function Fragment(node, context) {
 				'$.add_locations',
 				call,
 				b.member(b.id(context.state.analysis.name), b.id('$.FILENAME'), true),
-				serialize_locations(state.locations)
+				build_locations(state.locations)
 			);
 		}
 
@@ -184,7 +184,7 @@ export function Fragment(node, context) {
 	}
 
 	if (state.update.length > 0) {
-		body.push(serialize_render_stmt(state.update));
+		body.push(build_render_statement(state.update));
 	}
 
 	body.push(...state.after_update);
@@ -221,13 +221,13 @@ function get_template_function(namespace, state) {
 /**
  * @param {SourceLocation[]} locations
  */
-function serialize_locations(locations) {
+function build_locations(locations) {
 	return b.array(
 		locations.map((loc) => {
 			const expression = b.array([b.literal(loc[0]), b.literal(loc[1])]);
 
 			if (loc.length === 3) {
-				expression.elements.push(serialize_locations(loc[2]));
+				expression.elements.push(build_locations(loc[2]));
 			}
 
 			return expression;