Release Protocol 23 #805
Merged
Release Protocol 23 #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 1. Run the generator:
Change the commit hash to the right sha of stellar/stellar-xdr.
Add any new filenames (if needed: here Stellar-exporter.x for Galexie).
Run `make reset-xdr` from the project root.
* 2. Post-generation fixups to work around bugs or project-specific stuff:
* Move `xdr.Operation` into a hidden namespace to avoid conflicts with the
SDK's `Operation`.
* Minimize the diff by running `sed -ie s/\"/\'/g types/{curr,next}.d.ts`
(because the generator uses a different prettier config--this could
probably be fixed in the generator itself, but this is easy enough
for now).
* Add workarounds:
- `type Hash = Opaque[];` is a necessary alias that doesn't get gen'd
- `Hyper`, `UnsignedHyper`, and `ScSpecEventV0` need their signatures
fixed because it should take a proper `Array` instead of a naked `[]`
(enforced by `yarn lint`).
- Some constants aren't generated correctly, ref. the linked issue
* 3. Accommodate XDR additions or renames:
* This accounts for any fields that encountered a rename as part
of the new XDR version. In this case, `readBytes` was renamed to
`diskReadBytes` because it's measured differently as a result of
Core's state living in memory rather than on disk in most cases.
* It also accounts for the unused extension point actually having
a name now, so `xdr.ExtensionPoint` needs to use the structure-
specific `xdr.SorobanTransactionDataExt`, instead.
* Add docs to README for completeness
* Migrate to @noble/curves instead of sodium+nacl
|
Size Change: +147 kB (+4.46%) Total Size: 3.44 MB
|
* Prevent CBs and LPs from being used as arguments
* Remove secret keys from docs
sreuland
approved these changes
Jun 25, 2025
* Upgrade packages, add changelog, bump version * Bump node version, drop sodium-native refs * Update jobs to latest and Node 20 * Update tag used for publishing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.