Migrate cryptographic libraries to use modern @noble/curves. #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Size Change: +101 kB (+3.03%) Total Size: 3.42 MB
|
xiv
approved these changes
Jun 12, 2025
Shaptic
added a commit
that referenced
this pull request
Jun 18, 2025
* Migrate to @noble/curves instead of sodium+nacl
This was referenced Jun 18, 2025
Shaptic
added a commit
that referenced
this pull request
Jun 25, 2025
* Add strkey support for liquidity pools and claimable balances (#799) * Regenerate XDR with latest Protocol 23 version (#800) * Migrate cryptographic libraries to use modern @noble/curves. (#802) * Add support for encoding `Address` to/from new `StrKey`s (#801) * Allow specifying mixed types for vectors in `nativeToScVal` (#803) * Prepare v14.0.0-rc.1, Protocol 23 for release (#804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having two methods is janky, sodium-native doesn't build on some systems, and @noble/curves is an audited, modern, high-performance library that achieves the same goals.