Add support of numpy 2.0.0b1 #448
Merged
+50
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarpent
requested changes
Mar 15, 2024
jcarpent
reviewed
Mar 15, 2024
jcarpent
reviewed
Mar 15, 2024
|
@duburcqa Thanks for the contribution to support the latest NumPy change. Yet, it seems important to first extend the support of EigenPy, then change some variable names if they improve the readability. Please make these two stages into two different PRs. |
|
I will fix support of |
duburcqa
force-pushed
the
numpy_2
branch
3 times, most recently
from
20b0663 to
8a9f0e7
Compare
for more information, see https://pre-commit.ci
|
The CI is passing ! |
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Apr 22, 2024
## [3.5.0] - 2024-04-14
### Added
- Allow use of installed JRL-cmakemodule (stack-of-tasks/eigenpy#446)
- Support of Numpy 2.0.0b1 (stack-of-tasks/eigenpy#448)
- Support new primitive type (char, int8_t, uint8_t, int16_t, uint16_t, uint32_t, uint64_t) ()stack-of-tasks/eigenpy#455)
- Support conversion between signed <-> unsigned integers (stack-of-tasks/eigenpy#455)
- Support conversion between complex numbers (stack-of-tasks/eigenpy#455)
### Fixed
- Fix unit test build in C++11 (stack-of-tasks/eigenpy#442)
- Fix unit test function signature [#443](stack-of-tasks/eigenpy#443)
- Fix CMake export (stack-of-tasks/eigenpy#446)
- Fix `int` management on Windows (stack-of-tasks/eigenpy#455)
- Fix `long long` management on Mac (stack-of-tasks/eigenpy#455)
- Allow to run test in the build directory on Windows (stack-of-tasks/eigenpy#457)
### Removed
- Remove casting when converting from Eigen scalar to Numpy scalar.
This should not remove any functionality since Numpy array are created from the Eigen scalar type
(stack-of-tasks/eigenpy#455)
|
Thank you both for your hard work here! 🙏 Am curious, when building wheels for 3.5.0 or 3.5.1, were they built with NumPy 1 or 2? |
|
Numpy 1, there is still work to do to fully support numpy 2 in pre-compiled binaries. |
|
Ok thanks Alexis! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #447
It requires a follow-up PR in Boost::Python itself here, but it does not prevent from merging this PR.