wip: Replaces View.showRendering et al with a wrapper interface #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
commented
Jan 6, 2022
| * uses [map] to extract the [InnerT] instance from [OuterT] and makes the function call. | ||
| */ | ||
| @WorkflowUiExperimentalApi | ||
| public class DecorativeScreenViewFactory<OuterT : Screen, InnerT : Screen>( |
There was a problem hiding this comment.
Expecting to delete this.
rjrjr
commented
Jan 6, 2022
| import android.view.ViewGroup | ||
| import kotlin.reflect.KClass | ||
|
|
||
| /** |
There was a problem hiding this comment.
This is still deprecated, but its seems obnoxious to delete its copious kdoc when there is no direct analog in the new world.
rjrjr
force-pushed
the
ray/workflow-view
branch
from
38faa92 to
0dd2ace
Compare
… remember to delete DecorativeScreenViewFactory and port the tests for it.
rjrjr
force-pushed
the
ray/workflow-view
branch
from
0dd2ace to
66f28f5
Compare
|
Starting to feel like a dead end, deets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #606, fixes #413