Kotlin 2.0.21 & Return 'out RenderingT' variance #1328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
| @@ -0,0 +1 @@ | |||
| registry=https://registry.yarnpkg.com No newline at end of file | |||
There was a problem hiding this comment.
Another attempt to try and prevent local config from changing the registry specified by yarn.lock when we regenerate it for new versions. The previous .yarnrc did not work 🤔 . Either way I've manually corrected the yarn.lock again.
ijwhelan
approved these changes
May 23, 2025
We do rely on covariance for `RenderingT` for Workflow subtypes that subtype the `RenderingT`. Also we don't need to remove it due to UnsafeVariance.
steve-the-edwards
force-pushed
the
sedwards/add-render-covariance
branch
from
c653ae3 to
2369102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1327
We do rely on covariance for
RenderingTfor Workflow subtypes that subtype theRenderingT. Also we don't need to remove it due to UnsafeVariance.Also dropping back down to
2.0.21from2.1.21since that is what we currently use internally and this way we don't have to worry about matching binary compatibility.